Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22613 )
Change subject: IMPALA-13844: Support usage of strings directly in rapidjson ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22613/1/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22613/1/be/src/catalog/catalog-server.cc@1135 PS1, Line 1135: ThriftDebugStringNoThrow(result), document->GetAllocator()); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/22613/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/22613/1/be/src/service/impala-http-handler.cc@1053 PS1, Line 1053: Value debug_string(ThriftDebugString(result), document->GetAllocator()); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. -- To view, visit http://gerrit.cloudera.org:8080/22613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c6f17690f7a2e958a6dfbb3637832f5ab6ee53 Gerrit-Change-Number: 22613 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 11 Mar 2025 21:56:17 +0000 Gerrit-HasComments: Yes
