Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22496 )
Change subject: IMPALA-13074: Add sink node to Web UI's graphical plan for DDL/DML queries ...................................................................... Patch Set 10: (1 comment) The code looks good to me, too. As for testing, I like the idea of creating the base tests first in IMPALA-13824 but then right after that some tests (including sink nodes) will have to be changed in this patch. So maybe the 3rd option makes the most sense to me. http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc@1160 PS8, Line 1160: label_detail_str = to_string(sink.table_sink.action); : break; > Added DCHECK. Sorry, I forgot to check that there were more values of this enum besides MERGE_SINK. The DCHECK makes it clear, thanks for adding it! -- To view, visit http://gerrit.cloudera.org:8080/22496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bd442f6499efde7406d87c2b1fd1b46a45381b Gerrit-Change-Number: 22496 Gerrit-PatchSet: 10 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 14 Mar 2025 08:51:01 +0000 Gerrit-HasComments: Yes
