Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22496 )
Change subject: IMPALA-13074: WRITE TO HDFS node is omitted from Web UI graphic plan ...................................................................... Patch Set 8: (4 comments) Thanks for fixing this! I just left a few additional nits. I see you already opened a Jira for creating unit tests. I would prefer to include some tests in this patch set. http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc@1069 PS8, Line 1069: summary is stored with -1 as id if it is for a data sink at the root of a fragment nit: Summary [...] fragment. http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc@1160 PS8, Line 1160: default: : break; Unnecessary empty default. http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc@1219 PS8, Line 1219: all sink has -1 as node_id, we want to store the summary of the first one (the root : // of the plan tree) and insert will not overwrite the existing value : // if the key is already present nit: All [...] present. http://gerrit.cloudera.org:8080/#/c/22496/8/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/22496/8/common/thrift/Query.thrift@1043 PS8, Line 1043: e nit: capital E -- To view, visit http://gerrit.cloudera.org:8080/22496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bd442f6499efde7406d87c2b1fd1b46a45381b Gerrit-Change-Number: 22496 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 11 Mar 2025 10:18:26 +0000 Gerrit-HasComments: Yes
