Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22496 )
Change subject: IMPALA-13074: WRITE TO HDFS node is omitted from Web UI graphic plan ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc@1146 PS8, Line 1146: std:: nit: no need for std::, as "common/names.h" is included http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc@1153 PS8, Line 1153: if (sink.child_data_sinks.size() > 1) { no need of this enclosing if stmt, as the for-loop starts from i = 1 http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc@1168 PS8, Line 1168: summary_it != summaries.end() If the summary must be always there, we could have a DCHECK instead/also. http://gerrit.cloudera.org:8080/#/c/22496/8/be/src/service/impala-http-handler.cc@1231 PS8, Line 1231: fragment.output_sink.type == TDataSinkType::type::MULTI_DATA_SINK To support MERGE statements as well, you also need to add MERGE_SINK. -- To view, visit http://gerrit.cloudera.org:8080/22496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bd442f6499efde7406d87c2b1fd1b46a45381b Gerrit-Change-Number: 22496 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 16:03:20 +0000 Gerrit-HasComments: Yes
