Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22831 )
Change subject: IMPALA-11672: Update 'transient_lastDdlTime' for Iceberg tables ...................................................................... Patch Set 2: (2 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/22831/2/tests/metadata/test_last_ddl_time_update.py File tests/metadata/test_last_ddl_time_update.py: http://gerrit.cloudera.org:8080/#/c/22831/2/tests/metadata/test_last_ddl_time_update.py@173 PS2, Line 173: _create_table You could also create non-integrated Iceberg tables, by setting table property 'iceberg.catalog'='hadoop.tables', and expect that the behavior is in line with integrated Iceberg tables. http://gerrit.cloudera.org:8080/#/c/22831/2/tests/metadata/test_last_ddl_time_update.py@271 PS2, Line 271: h.expect_ddl_time_change("alter table %(TBL)s execute expire_snapshots(now())") Please test all the alter table statements that we support for Iceberg tables. So we make sure the behavior remains the same even if we refactor the code. -- To view, visit http://gerrit.cloudera.org:8080/22831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5f63b50bd37c80faf482c4baf4221be857c54b Gerrit-Change-Number: 22831 Gerrit-PatchSet: 2 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 30 Apr 2025 14:01:23 +0000 Gerrit-HasComments: Yes
