Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22831 )

Change subject: IMPALA-11672: Update 'transient_lastDdlTime' for Iceberg tables
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

LGTM!

http://gerrit.cloudera.org:8080/#/c/22831/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22831/3//COMMIT_MSG@20
PS3, Line 20: 'transient_lastDdlTime' table property because rename is a
            : catalog-level operation for Iceberg tables, and not table-level.
            :
> For managed tables, that would be a parallel update to HMS, which could 
> result in data loss, IIUC.

No, only if you do it via HMS API directly. If you use the Iceberg Transaction 
API to set the table property then we should be fine.



--
To view, visit http://gerrit.cloudera.org:8080/22831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e5f63b50bd37c80faf482c4baf4221be857c54b
Gerrit-Change-Number: 22831
Gerrit-PatchSet: 4
Gerrit-Owner: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 09 May 2025 14:40:42 +0000
Gerrit-HasComments: Yes

Reply via email to