Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22831 )
Change subject: IMPALA-11672: Update 'transient_lastDdlTime' for Iceberg tables ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22831/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22831/3//COMMIT_MSG@20 PS3, Line 20: 'transient_lastDdlTime' table property because rename is a : catalog-level operation for Iceberg tables, and not table-level. : > You are right. Thank you for trying it out. Yeah, setting 'transient_lastDdlTime' before the RENAME could be slightly controversial. Avoiding setting the property on no-op (oldName == newName) should be easy, but of course we can get an error anytime. Personally I wouldn't worry about it too much. It shouldn't cause serious problems to increase 'transient_lastDdlTime' spuriously (I know, famous last words.. :) ). So let's further discuss and handle it separately in case we need to revert that behavior. And as you mentioned, we might find a way to update 'transient_lastDdlTime' after the RENAME. -- To view, visit http://gerrit.cloudera.org:8080/22831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e5f63b50bd37c80faf482c4baf4221be857c54b Gerrit-Change-Number: 22831 Gerrit-PatchSet: 5 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 09 May 2025 16:58:07 +0000 Gerrit-HasComments: Yes
