Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: IMPALA-13820: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 28: Code-Review+1 (3 comments) LGTM! Just a few nits. http://gerrit.cloudera.org:8080/#/c/22527/28//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22527/28//COMMIT_MSG@40 PS28, Line 40: communication (e.g. krpc) is not ready for ipv6 nit: If possible, can you elaborate on what classes (or files) inside impala source would require the IPv6 support. Just want to make sure I am not missing any dependency from Kudu side. http://gerrit.cloudera.org:8080/#/c/22527/28/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/22527/28/be/src/util/network-util.cc@88 PS28, Line 88: char addr_buf[INET6_ADDRSTRLEN]; nit: Apart from IPv6 address taking up to 46 bytes, is there any specific reason you chose INET6_ADDRSTRLEN instead of keeping it at 64? http://gerrit.cloudera.org:8080/#/c/22527/28/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22527/28/shell/impala_shell/impala_shell.py@996 PS28, Line 996: def __parse_host_port(addr): nit: Does this handle addr with whitespaces or addr can never have those? -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 28 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 03 Jun 2025 15:15:49 +0000 Gerrit-HasComments: Yes
