Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: IMPALA-13820: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 30: (3 comments) http://gerrit.cloudera.org:8080/#/c/22527/28//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22527/28//COMMIT_MSG@40 PS28, Line 40: communication (e.g. krpc) is not ready for ipv6 > I will look into this, but we use a lot of Kudu classes, so I would separat Ack http://gerrit.cloudera.org:8080/#/c/22527/28/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/22527/28/be/src/util/network-util.cc@88 PS28, Line 88: char addr_buf[INET6_ADDRSTRLEN]; > no, I didn't realize that INET6_ADDRSTRLEN is less than 64 I would prefer to keep it INET6_ADDRSTRLEN, that aligns with Kudu implementation. However, if this requires to be 64 for some reason in impala, you might want to take that into consideration. Otherwise, INET6_ADDRSTRLEN looks ok to me. http://gerrit.cloudera.org:8080/#/c/22527/28/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22527/28/shell/impala_shell/impala_shell.py@996 PS28, Line 996: self._print_if_verbose("Goodbye " + self.user) > I can't think of any use case when white space would be relevant. The optio Ack -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 30 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 10 Jun 2025 14:41:22 +0000 Gerrit-HasComments: Yes
