Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: IMPALA-13820: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 29: (3 comments) http://gerrit.cloudera.org:8080/#/c/22527/28//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22527/28//COMMIT_MSG@40 PS28, Line 40: communication (e.g. krpc) is not ready for ipv6 > nit: If possible, can you elaborate on what classes (or files) inside impal I will look into this, but we use a lot of Kudu classes, so I would separate this from the current patch. Tried to collect quickly what we import: git grep "kudu/rpc" | grep -v "be/src/kudu" | cut -d' ' -f2 | sort | uniq "kudu/rpc/acceptor_pool.h" "kudu/rpc/inbound_call.h" "kudu/rpc/messenger.h" "kudu/rpc/remote_user.h" "kudu/rpc/result_tracker.h" "kudu/rpc/rpc_context.h" "kudu/rpc/rpc_controller.h" "kudu/rpc/rpc_header.pb.h" "kudu/rpc/rpc_header.proto"; "kudu/rpc/rpc_introspection.pb.h" "kudu/rpc/rpc_service.h" "kudu/rpc/rpc_sidecar.h" "kudu/rpc/sasl_common.h" "kudu/rpc/service_if.h" "kudu/rpc/service_pool.h" "kudu/rpc/service_queue.h" "kudu/rpc/user_credentials.h" git grep "kudu/util" | grep -v "be/src/kudu" | cut -d' ' -f2 | sort | uniq (dropped the ones that didn't look network related at all) "kudu/util/countdown_latch.h" "kudu/util/curl_util.h" "kudu/util/env.h" "kudu/util/net/net_util.h" "kudu/util/net/sockaddr.h" "kudu/util/net/socket.h" "kudu/util/openssl_util.h" "kudu/util/path_util.h" "kudu/util/test_macros.h" "kudu/util/test_util.h" "kudu/util/trace.h" "kudu/util/url-coding.h" "kudu/util/web_callback_registry.h" git grep "kudu/security" | grep -v "be/src/kudu" | cut -d' ' -f2 | sort | uniq "kudu/security/gssapi.h" "kudu/security/init.h" "kudu/security/security_flags.h" "kudu/security/test/mini_kdc.h" "kudu/security/tls_context.h" "kudu/security/tls_handshake.h" http://gerrit.cloudera.org:8080/#/c/22527/28/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/22527/28/be/src/util/network-util.cc@88 PS28, Line 88: char addr_buf[INET6_ADDRSTRLEN]; > nit: Apart from IPv6 address taking up to 46 bytes, is there any specific r no, I didn't realize that INET6_ADDRSTRLEN is less than 64 I can return it to 64 if it seems better like that. http://gerrit.cloudera.org:8080/#/c/22527/28/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22527/28/shell/impala_shell/impala_shell.py@996 PS28, Line 996: self._print_if_verbose("Goodbye " + self.user) > nit: Does this handle addr with whitespaces or addr can never have those? I can't think of any use case when white space would be relevant. The option parser already strips it from start/end, and I don't see why there would be any in the middle. The ip4 case handles some weird cases, e.g. impala-shell can be started with -i "localhost :" parameter, so I don't want to break this, but I don't see why someone would pass argument like that. -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 29 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 06 Jun 2025 15:36:54 +0000 Gerrit-HasComments: Yes
