Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23044 )
Change subject: IMPALA-14142: Fix TestIcebergV2Table.test_compute_stats_table_sampling ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23044/1/tests/metadata/test_stats_extrapolation.py File tests/metadata/test_stats_extrapolation.py: http://gerrit.cloudera.org:8080/#/c/23044/1/tests/metadata/test_stats_extrapolation.py@123 PS1, Line 123: v > flake8: U100 Unused argument 'vector' Lets drop 'vector' parameter here. http://gerrit.cloudera.org:8080/#/c/23044/1/tests/metadata/test_stats_extrapolation.py@229 PS1, Line 229: percentage Assert percentage is between [0, 100]. Otherwise, consider changing percentage to fraction and change the formula to return 1.0 - fraction * 0.9 -- To view, visit http://gerrit.cloudera.org:8080/23044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98b07b156aad300827c9e1b7970b8dfacfc6d251 Gerrit-Change-Number: 23044 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 18 Jun 2025 14:24:18 +0000 Gerrit-HasComments: Yes
