Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23044 )

Change subject: IMPALA-14142: Fix 
TestIcebergV2Table.test_compute_stats_table_sampling
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/23044/1/tests/metadata/test_stats_extrapolation.py
File tests/metadata/test_stats_extrapolation.py:

http://gerrit.cloudera.org:8080/#/c/23044/1/tests/metadata/test_stats_extrapolation.py@123
PS1, Line 123: v
> flake8: U100 Unused argument 'vector'
Done


http://gerrit.cloudera.org:8080/#/c/23044/1/tests/metadata/test_stats_extrapolation.py@123
PS1, Line 123: v
> Lets drop 'vector' parameter here.
Done


http://gerrit.cloudera.org:8080/#/c/23044/1/tests/metadata/test_stats_extrapolation.py@229
PS1, Line 229: percentage
> Assert percentage is between [0, 100]. Otherwise, consider changing percent
Done


http://gerrit.cloudera.org:8080/#/c/23044/1/tests/metadata/test_stats_extrapolation.py@229
PS1, Line 229:
> flake8: W292 no newline at end of file
Done



--
To view, visit http://gerrit.cloudera.org:8080/23044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b07b156aad300827c9e1b7970b8dfacfc6d251
Gerrit-Change-Number: 23044
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 19 Jun 2025 09:10:02 +0000
Gerrit-HasComments: Yes

Reply via email to