Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23044 )

Change subject: IMPALA-14142: Fix 
TestIcebergV2Table.test_compute_stats_table_sampling
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

Thanks for the review! Carry +2

http://gerrit.cloudera.org:8080/#/c/23044/2/tests/metadata/test_stats_extrapolation.py
File tests/metadata/test_stats_extrapolation.py:

http://gerrit.cloudera.org:8080/#/c/23044/2/tests/metadata/test_stats_extrapolation.py@58
PS2, Line 58: 
self.client.set_configuration_option('compute_stats_min_sample_size', '0')
            :
> nit: self.client.set_configuration_option('compute_stats_min_sample_size',
Done


http://gerrit.cloudera.org:8080/#/c/23044/2/tests/metadata/test_stats_extrapolation.py@124
PS2, Line 124: self.client.set_configuration_option('compute_stats_min_sa
> nit: self.client.set_configuration_option('compute_stats_min_sample_size',
Done



--
To view, visit http://gerrit.cloudera.org:8080/23044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b07b156aad300827c9e1b7970b8dfacfc6d251
Gerrit-Change-Number: 23044
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Fri, 20 Jun 2025 09:37:27 +0000
Gerrit-HasComments: Yes

Reply via email to