Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23073 )
Change subject: IMPALA-13887: Incorporate column/field information into cache key ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23073/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23073/1//COMMIT_MSG@17 PS1, Line 17: This nit. This change or This patch http://gerrit.cloudera.org:8080/#/c/23073/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/23073/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@488 PS1, Line 488: path_ Should we check if label_ != null instead? Maybe I'm missing something -- To view, visit http://gerrit.cloudera.org:8080/23073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa777452daf66851b86383651d35e1b0a5f262 Gerrit-Change-Number: 23073 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 25 Jun 2025 23:14:40 +0000 Gerrit-HasComments: Yes
