Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23073 )
Change subject: IMPALA-13887: Incorporate column/field information into cache key ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23073/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23073/1//COMMIT_MSG@17 PS1, Line 17: This > nit. This change or This patch Done http://gerrit.cloudera.org:8080/#/c/23073/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/23073/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@488 PS1, Line 488: path_ > Should we check if label_ != null instead? Maybe I'm missing something At the moment, we're only interested in label_ when it is a string representation of path_, because the path_ has the column/field names. label_ can be set to something else via setLabel() and we don't want to include it in that case. Maybe that will change in the future, but for now this is all we need. -- To view, visit http://gerrit.cloudera.org:8080/23073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa777452daf66851b86383651d35e1b0a5f262 Gerrit-Change-Number: 23073 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 26 Jun 2025 23:24:15 +0000 Gerrit-HasComments: Yes
