Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23073 )
Change subject: IMPALA-13887: Incorporate column/field information into cache key ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23073/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/23073/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@488 PS1, Line 488: path_ > At the moment, we're only interested in label_ when it is a string represen Thanks for the explanation. How about extending the comment a bit, like "The label is a string representation of the path when path is set. Otherwise, it may be set to something unrelated" -- To view, visit http://gerrit.cloudera.org:8080/23073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebfa777452daf66851b86383651d35e1b0a5f262 Gerrit-Change-Number: 23073 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 27 Jun 2025 00:38:41 +0000 Gerrit-HasComments: Yes
