Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23106 )
Change subject: IMPALA-14163: (Addendum) Always reset max-query-mem-limit ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Thanks Riza for the fix. Just some minor questions. http://gerrit.cloudera.org:8080/#/c/23106/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/23106/1/be/src/scheduling/admission-controller.cc@a1659 PS1, Line 1659: This log was moved to AdmitQuery(), but VLOG_RPC in AdmitQuery() appears to require a higher verbosity level. Maybe we should keep this log here #define VLOG_RPC VLOG(2) #define VLOG_QUERY VLOG(1) http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py@a1276 PS1, Line 1276: not familiar with the make_copy logic yet, trying to understand how removing it affects the test http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py@1509 PS1, Line 1509: max-query-mem-limit = min-query-mem-limit config_str is max-query-mem-limit, is setting max-query-mem-limit also changing the min-query-mem-limit? -- To view, visit http://gerrit.cloudera.org:8080/23106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41f671b8fb3eabf263041a834b54740fbacda68e Gerrit-Change-Number: 23106 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 02 Jul 2025 03:12:06 +0000 Gerrit-HasComments: Yes
