Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23106 )
Change subject: IMPALA-14163: (Addendum) Always reset max-query-mem-limit ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23106/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/23106/1/be/src/scheduling/admission-controller.cc@a1659 PS1, Line 1659: > This log was moved to AdmitQuery(), but VLOG_RPC in AdmitQuery() appears to Good point. I missed that. Restored. http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py@a1276 PS1, Line 1276: > not familiar with the make_copy logic yet, trying to understand how removin With this removed, only test_pool_config_change_while_queued will use make_copy=True parameter. It does not affect this test_pool_mem_limit_configs because, unlike test_pool_config_change_while_queued, it is not mutating either of copy-mem-limit-test-llama-site.xml or copy-mem-limit-test-fair-scheduler.xml. http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py@1509 PS1, Line 1509: max-query-mem-limit = min-query-mem-limit > config_str is max-query-mem-limit, is setting max-query-mem-limit also chan Yes. This is why not resetting max-query-mem-limit cause the second run of test_pool_config_change_while_queued (under TestAdmissionControllerWithACService) fail. Queries from next run will have all its mem_limit capped to 25MB and cause queueing instead of rejection. -- To view, visit http://gerrit.cloudera.org:8080/23106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41f671b8fb3eabf263041a834b54740fbacda68e Gerrit-Change-Number: 23106 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 02 Jul 2025 03:22:16 +0000 Gerrit-HasComments: Yes
