Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23106 )
Change subject: IMPALA-14163: (Addendum) Always reset max-query-mem-limit ...................................................................... Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/23106/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/23106/1/be/src/scheduling/admission-controller.cc@a1659 PS1, Line 1659: > Good point. I missed that. Restored. Done http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py@a1276 PS1, Line 1276: > With this removed, only test_pool_config_change_while_queued will use make_ Ack http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py@1488 PS1, Line 1488: config.set_config_value(pool_name, config_str, 1) What is the value of min-query-mem-limit, while we seem to set the max-query-mem-limit to 1 here? http://gerrit.cloudera.org:8080/#/c/23106/1/tests/custom_cluster/test_admission_controller.py@1509 PS1, Line 1509: max-query-mem-limit = min-query-mem-limit > Yes. Ack -- To view, visit http://gerrit.cloudera.org:8080/23106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41f671b8fb3eabf263041a834b54740fbacda68e Gerrit-Change-Number: 23106 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 02 Jul 2025 03:47:50 +0000 Gerrit-HasComments: Yes
