Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21800 )
Change subject: IMPALA-13223: Fix bootstrap-build.sh for platforms without Python2 ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21800/5/bin/bootstrap_build.sh File bin/bootstrap_build.sh: http://gerrit.cloudera.org:8080/#/c/21800/5/bin/bootstrap_build.sh@46 PS5, Line 46: else : PACKAGES="${PACKAGES} python-is-python3 python-dev-is-python3" : fi > I'm sorry Surya, could you give me a bit more context? I don't understand t Never mind; I've just re-read my commit message, which made me realize what you were responding to. I think it's OK not to separate out the packages ('language-pack-en' and 'wget') that were added for the Docker environment: - |apt-get install" is (largely) idempotent, so installing a package that's already installed does no harm. The PACKAGES list can be read as a declarative list of components we want/need in an Ubuntu environment for Impala compilation - This is a pretty simple script. It prepares only a minimal environment (as stated in the header comment), so if anything fancy is needed, it usually goes into bootstrap_system.sh. This is just to enable a bare system to compile Impala, nothing more. With all this said, this is just my opinion, I don't feel really strongly about these issues. -- To view, visit http://gerrit.cloudera.org:8080/21800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ade35395afded4e130b79eab8c27c6171b50d6 Gerrit-Change-Number: 21800 Gerrit-PatchSet: 5 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 03 Jul 2025 16:33:18 +0000 Gerrit-HasComments: Yes
