Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21800 )
Change subject: IMPALA-13223: Fix bootstrap-build.sh for platforms without Python2 ...................................................................... Patch Set 7: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21800/5/bin/bootstrap_build.sh File bin/bootstrap_build.sh: http://gerrit.cloudera.org:8080/#/c/21800/5/bin/bootstrap_build.sh@48 PS5, Line 48: fi > As the reason for including these packages is different, does it make sense Done http://gerrit.cloudera.org:8080/#/c/21800/5/bin/bootstrap_build.sh@48 PS5, Line 48: fi > I'm sorry Surya, could you give me a bit more context? I don't understand t Ack. I had interpreted from the commit message that some of the packages were required only for docker. So, I was suggesting to specify an additional conditional. If that was not the case, I'm sorry for the confusion. -- To view, visit http://gerrit.cloudera.org:8080/21800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94ade35395afded4e130b79eab8c27c6171b50d6 Gerrit-Change-Number: 21800 Gerrit-PatchSet: 7 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 16 Jul 2025 15:41:43 +0000 Gerrit-HasComments: Yes
