Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23175/1//COMMIT_MSG@25 PS1, Line 25: 'impala.preload-block-locations-for-scheduling': 'false' Is there any valid use case for setting these configs to "true"? As far as I understand it, if 'impala.preload-block-locations-for-scheduling' is set to false, even if we set e.g. 'impala.preload-block-locations-for-scheduling.authority.mycluster' to true it will not have any effect. If true, I think we should mention it here. http://gerrit.cloudera.org:8080/#/c/23175/1/bin/create-test-configuration.sh File bin/create-test-configuration.sh: http://gerrit.cloudera.org:8080/#/c/23175/1/bin/create-test-configuration.sh@138 PS1, Line 138: export CORE_SITE_VARIANT=disable_block_locations Shouldn't we reset this env var for future safety? Or instead of exporting it, just use it for the command? -- To view, visit http://gerrit.cloudera.org:8080/23175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867 Gerrit-Change-Number: 23175 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 15 Jul 2025 14:27:05 +0000 Gerrit-HasComments: Yes
