Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config ...................................................................... Patch Set 3: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@583 PS2, Line 583: return BLOCK_LOCATIONS_FOR_FS_SCHEMES.contains(fs.getScheme()) && : !NO_BLOCK_LOCATIONS_FOR_AUTHORITIES.contains(fs.getUri().getAuthority()); : } > These could be simplified to a single set, which is empty if PRELOAD_BLOCK_ Good idea, done. http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@46 PS2, Line 46: public class FileMetadataLoaderTest { > nit: unused import Done http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test File testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test: http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test@28 PS2, Line 28: # 'lineitem_sixblocks' contains a single data file with six HDFS blocks. Without > nit: please mention that this table just have a single file. Done http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test@35 PS2, Line 35: ---- RUNTIME_PROFILE > nit: please comment that this is matching the ExecSummary section of the pr Done. Also fixed the expression to be the same as L45. -- To view, visit http://gerrit.cloudera.org:8080/23175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867 Gerrit-Change-Number: 23175 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 16 Jul 2025 14:46:54 +0000 Gerrit-HasComments: Yes
