Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23175 )
Change subject: IMPALA-14138: Manually disable block location loading via Hadoop config ...................................................................... Patch Set 2: Code-Review+1 (3 comments) The patch looks pretty good! http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/23175/2/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@46 PS2, Line 46: import org.opensaml.xmlsec.signature.P; nit: unused import http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test File testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test: http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test@28 PS2, Line 28: # Without block information we schedule the whole data file to a single SCAN operator. nit: please mention that this table just have a single file. http://gerrit.cloudera.org:8080/#/c/23175/2/testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test@35 PS2, Line 35: row_regex: 00:SCAN [A-Z0-9]+[ ]+1[ ]+1[ ]+.* nit: please comment that this is matching the ExecSummary section of the profile. I thought it's in the query plan so got confused at the begining. Is it intented to be different than the expression on L45? -- To view, visit http://gerrit.cloudera.org:8080/23175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c7a6a91f657c99792db885991b7677d2c240867 Gerrit-Change-Number: 23175 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 16 Jul 2025 10:58:43 +0000 Gerrit-HasComments: Yes
