Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23174 )
Change subject: IMPALA-14227: In HA failover, passive catalogd should apply pending HMS events before being active ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc@902 PS5, Line 902: while (latest_hms_event_id == -1 && timeout_timer.ElapsedTime() < timeout_ns) { Explain with comment why this loop is needed (why latest_hms_event_id == -1 should be retried). How often is the retry? There is no sleep/backoff between retry here. Is this OK? http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc@908 PS5, Line 908: // Don't need latest event id anymore. nit: Elaborate this code comment more. Maybe something along this line: Now that we figure out latest_hms_event_id from HMS, we loop and wait until last_synced_event_id catch up with this latest_hms_event_id or timeout passed. -- To view, visit http://gerrit.cloudera.org:8080/23174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4fcb0e27c14197f79625749949b47c033a5f31 Gerrit-Change-Number: 23174 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 16 Jul 2025 14:57:35 +0000 Gerrit-HasComments: Yes
