Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23174 )
Change subject: IMPALA-14227: In HA failover, passive catalogd should apply pending HMS events before being active ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/23174/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23174/4//COMMIT_MSG@11 PS4, Line 11: However, it could still use : a stale metadata cache when some pending HMS events generated by the : previous active catalogd are not applied yet. > How do we handle the case when hms_event_polling is disabled? Reset is the Good point! It's impossible for the passive catalogd to keeps the metadata up-to-date with HMS event processing disabled. Added a flag validator for this. http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc@188 PS5, Line 188: will reset > nit: transitioning? Done http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc@880 PS5, Line 880: > nit: Can we DCHECK that catalog_lock_ is owned here? Done http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc@902 PS5, Line 902: int64_t latest_hms_event_id = response.progress.latest_event_id; > Explain with comment why this loop is needed (why latest_hms_event_id == -1 I think if the HMS RPC failed by socket timeouts, it's OK to retry immediately. But if it's failed immediately, e.g. due to rate limiting in HMS (if it has), we'd better sleep for a while. Added a sleep of 100ms. http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc@908 PS5, Line 908: status = catalog_->GetEventProcessor > nit: Elaborate this code comment more. Maybe something along this line: Done -- To view, visit http://gerrit.cloudera.org:8080/23174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4fcb0e27c14197f79625749949b47c033a5f31 Gerrit-Change-Number: 23174 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 17 Jul 2025 02:30:59 +0000 Gerrit-HasComments: Yes
