Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23472 )
Change subject: IMPALA-14466: Fix admissiond remote client retry timeout when ip is changed ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/23472/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23472/1//COMMIT_MSG@7 PS1, Line 7: Fix admissiond remote client retry timeout when ip is changed Maybe rephrase to "Remote client should not cache admissiond's IP when retrying AdmitQuery RPC" http://gerrit.cloudera.org:8080/#/c/23472/1//COMMIT_MSG@11 PS1, Line 11: endlessly The retry should only happen for the configured retry duration i.e admission_status_retry_time_ms & admission_max_retry_time_s. Maybe remove "endlessly" ? Did you mean the connection hangs when trying to connect to a non existent IP? http://gerrit.cloudera.org:8080/#/c/23472/1/be/src/scheduling/remote-admission-control-client.cc File be/src/scheduling/remote-admission-control-client.cc: http://gerrit.cloudera.org:8080/#/c/23472/1/be/src/scheduling/remote-admission-control-client.cc@157 PS1, Line 157: proxy->GetQueryStatus(get_status_req, &get_status_resp, &rpc_controller2), This might also access admissiond using stale IP in some cases, but not much we can do in that case as query state is already lost if admissiond restarts and so maybe this is okay? Do we know what's the default timeout in this case? Ideally we want the rpc to fail quickly in such case. -- To view, visit http://gerrit.cloudera.org:8080/23472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5857de84ce69902b902099f668e87d747f944aff Gerrit-Change-Number: 23472 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 26 Sep 2025 20:34:26 +0000 Gerrit-HasComments: Yes
