Yida Wu has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23472 )
Change subject: IMPALA-14466: Remote client should not cache admissiond's IP when retrying AdmitQuery RPC ...................................................................... IMPALA-14466: Remote client should not cache admissiond's IP when retrying AdmitQuery RPC The remote admission client's retry logic for AdmitQuery RPC did not handle cases where the admissiond restarts with a new IP address. The client would use the old proxy and retry against the old, stale ip, causing queries to time out. This change fixes the issue by adding the GetProxy() call inside the retry loop. This forces the client to re-resolve the admissiond's network address on each retry attempt, allowing it to discover the new endpoint and successfully reconnect. Tests: Passed admissiond related exhaustive ee tests. Since automatically change hosts might be difficult, manually test to change the /etc/hosts with following steps: 1. Start with --admission_service_host=localhost. 2. Change the 'localhost' in /etc/hosts to an inaccessible IP, like 127.0.0.2. 3. Submit a query, it will block in the retry logic. 4. While the query is blocked, change 'localhost' in /etc/hosts back to 127.0.0.1. 5. The query succeeded. Change-Id: I5857de84ce69902b902099f668e87d747f944aff Reviewed-on: http://gerrit.cloudera.org:8080/23472 Reviewed-by: Abhishek Rawat <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/scheduling/remote-admission-control-client.cc 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Abhishek Rawat: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/23472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5857de84ce69902b902099f668e87d747f944aff Gerrit-Change-Number: 23472 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
