Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23472 )
Change subject: IMPALA-14466: Remote client should not cache admissiond's IP when retrying AdmitQuery RPC ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23472/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23472/1//COMMIT_MSG@7 PS1, Line 7: Remote client should not cache admissiond's IP when retrying > Maybe rephrase to "Remote client should not cache admissiond's IP when retr Done http://gerrit.cloudera.org:8080/#/c/23472/1//COMMIT_MSG@11 PS1, Line 11: se the ol > The retry should only happen for the configured retry duration i.e admissio Nope, it won't hang, was trying to say it will keep retrying until timeout. Removed "endlessly". http://gerrit.cloudera.org:8080/#/c/23472/1/be/src/scheduling/remote-admission-control-client.cc File be/src/scheduling/remote-admission-control-client.cc: http://gerrit.cloudera.org:8080/#/c/23472/1/be/src/scheduling/remote-admission-control-client.cc@157 PS1, Line 157: proxy->GetQueryStatus(get_status_req, &get_status_resp, &rpc_controller2), > This might also access admissiond using stale IP in some cases, but not muc Did a test that the GetQueryStatus() will fail and exit immediately within a second if the proxy is inaccessible. Yeah, probably it is fine as the query state is already lost when admissiond restarts, maybe later if the admissiond can be recovered we can consider retry in this case. -- To view, visit http://gerrit.cloudera.org:8080/23472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5857de84ce69902b902099f668e87d747f944aff Gerrit-Change-Number: 23472 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 26 Sep 2025 22:55:39 +0000 Gerrit-HasComments: Yes
