Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23883 )
Change subject: IMPALA-572 impala-shell: add option to write profiles to a file ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23883/4/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/23883/4/tests/shell/test_shell_commandline.py@421 PS4, Line 421: """Test that writing profile with --profile_output writes the profile : into the file.""" nit: indentation looks unusual, see other functions http://gerrit.cloudera.org:8080/#/c/23883/4/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/23883/4/tests/shell/test_shell_interactive.py@313 PS4, Line 313: @pytest.mark.execute_serially can you try to get rid of execute_serially? see NamedTemporaryFile in other tests to get a file with unique name it could be also removed for some other tests like test_write_delimited - probably it was just copy pasted by mistake -- To view, visit http://gerrit.cloudera.org:8080/23883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8ce4ddcf013392b3c4d66941f07fb90f9c90c3c Gerrit-Change-Number: 23883 Gerrit-PatchSet: 4 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 12:26:01 +0000 Gerrit-HasComments: Yes
