Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23883 )
Change subject: IMPALA-572 impala-shell: add option to write profiles to a file ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py@1237 PS6, Line 1237: out_file = sys.stdout : if self.profile_output: : out_file = open(self.profile_output, 'a') This could be moved under if self.show_profiles or status: if profile: so we wouldn't open/close file handles unnecessarily. http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py@1255 PS6, Line 1255: else: : raise FatalShellException("Invalid value for query profile display mode") We don't close out_file on this branch. http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py@2466 PS6, Line 2466: if options.profile_output If output_file and profile_output are independent, then this shouldn't be nested under 'if options.output_file' -- To view, visit http://gerrit.cloudera.org:8080/23883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8ce4ddcf013392b3c4d66941f07fb90f9c90c3c Gerrit-Change-Number: 23883 Gerrit-PatchSet: 6 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 15:34:26 +0000 Gerrit-HasComments: Yes
