Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23883 )
Change subject: IMPALA-572 impala-shell: add option to write profiles to a file ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/23883/5/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23883/5/shell/impala_shell/impala_shell.py@1241 PS5, Line 1241: if self.show_profiles or status: : if profile: : query_profile_prefix = match_string_type("Query Runtime Profile:\n", profile) : if profile_display_mode == QueryAttemptDisplayModes.ALL: : print(que > You could use a variable to store the target for printing with a default va Done http://gerrit.cloudera.org:8080/#/c/23883/5/shell/impala_shell/impala_shell.py@2472 PS5, Line 2472: raise FatalShellException() > nit: please move the comment and the previous block's comment above, and gi Done http://gerrit.cloudera.org:8080/#/c/23883/5/shell/impala_shell/impala_shell.py@2474 PS5, Line 2474: if options.http_socket_timeout_s is not None: > I know it's mainly from the previous code part, but it seems a good time to Done -- To view, visit http://gerrit.cloudera.org:8080/23883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8ce4ddcf013392b3c4d66941f07fb90f9c90c3c Gerrit-Change-Number: 23883 Gerrit-PatchSet: 6 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 14:45:47 +0000 Gerrit-HasComments: Yes
