Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23883 )
Change subject: IMPALA-572 impala-shell: add option to write profiles to a file ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py@1237 PS6, Line 1237: if self.show_profiles or status: : try: : out_file = sys.stdout > This could be moved under Done http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py@1255 PS6, Line 1255: print(query_profile_prefix + query_profile, file=out_file) : else: > We don't close out_file on this branch. Done http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py@2466 PS6, Line 2466: > If output_file and profile_output are independent, then this shouldn't be n Done http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py@2469 PS6, Line 2469: with open(options.profile_output, 'w'): > nit: indentation is off by 2 Done -- To view, visit http://gerrit.cloudera.org:8080/23883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8ce4ddcf013392b3c4d66941f07fb90f9c90c3c Gerrit-Change-Number: 23883 Gerrit-PatchSet: 7 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 23 Jan 2026 08:03:21 +0000 Gerrit-HasComments: Yes
