Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23884 )
Change subject: IMPALA-14673 impala-shell: profile format argument ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/23884/4/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23884/4/shell/impala_shell/impala_shell.py@916 PS4, Line 916: if token.upper() == "PROFILE_FORMAT": : self.imp_client.profile_format = self.get_profile_format_id_from_string( : self.profile_format, raise_exception=False) With the shell option it seems clearer to me to add format as a parameter in client's get_runtime_profile() and pass self.profile_format there. http://gerrit.cloudera.org:8080/#/c/23884/4/shell/impala_shell/impala_shell.py@1255 PS4, Line 1255: # return default (string) : return 0 What is the intention here? -- To view, visit http://gerrit.cloudera.org:8080/23884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I032a5d0436f123d737d46d0b8cecbae09888a789 Gerrit-Change-Number: 23884 Gerrit-PatchSet: 4 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 26 Jan 2026 16:14:38 +0000 Gerrit-HasComments: Yes
