Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23884 )
Change subject: IMPALA-14673 impala-shell: profile format argument ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23884/4/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23884/4/shell/impala_shell/impala_shell.py@1255 PS4, Line 1255: # return default (string) : return 0 > What is the intention here? This is related to error handling, specifically with invalid input format from the user: The idea is to always print an error message as soon as the invalid format string input is parsed (for both command line arg and shell option). The alternative would be to only print it when trying to print the profile. An exception is raised only if the invalid value is set as a command line arg, so the shell doesn't exit if an invalid value is set as a runtime shell option. This return corresponds to trying to parse an invalid format string set as a runtime shell option. Currently, an error message is printed and the default "string" format is set in this case. -- To view, visit http://gerrit.cloudera.org:8080/23884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I032a5d0436f123d737d46d0b8cecbae09888a789 Gerrit-Change-Number: 23884 Gerrit-PatchSet: 4 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 06:30:15 +0000 Gerrit-HasComments: Yes
