Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24018 )
Change subject: IMPALA-14768: Add the operation type to the lineage graph ...................................................................... Patch Set 6: (4 comments) In patch set 6, I have addressed Daniel's comments on patch set 5 by updating the golden file of the front-end lineage test. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/24018/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24018/5//COMMIT_MSG@42 PS5, Line 42: actual lineage graph with the expected one in lineage.test run in the : frontend test. : > We have another lineage.test file at testdata/workloads/functional-planner/ Thanks Daniel for pointing this out! You are correct. I will revise patch set 5 accordingly. http://gerrit.cloudera.org:8080/#/c/24018/5/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java: http://gerrit.cloudera.org:8080/#/c/24018/5/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@814 PS5, Line 814: > Add operationType handling. Done http://gerrit.cloudera.org:8080/#/c/24018/5/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java@841 PS5, Line 841: > Add operationType handling. Done http://gerrit.cloudera.org:8080/#/c/24018/5/testdata/workloads/functional-planner/queries/PlannerTest/lineage.test File testdata/workloads/functional-planner/queries/PlannerTest/lineage.test: PS5: > Here is the other lineage.test, which should also include operationType. Done -- To view, visit http://gerrit.cloudera.org:8080/24018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb94120a9bb1b994d4e681ea98521035bcc6510e Gerrit-Change-Number: 24018 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 04 Mar 2026 00:12:20 +0000 Gerrit-HasComments: Yes
