Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24045 )
Change subject: IMPALA-14737 Part2: Add relaxed predicate pushdown for LIKE patterns with suffix ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/24045/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24045/3//COMMIT_MSG@16 PS3, Line 16: > nit: we have a 72 chars limit for the body of the commit message Done http://gerrit.cloudera.org:8080/#/c/24045/3/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java: http://gerrit.cloudera.org:8080/#/c/24045/3/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java@171 PS3, Line 171: Predicate '%s' can only be p > Currently, only the LIKE predicate can be partially converted, but for futu Done http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test: http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test@502 PS3, Line 502: PARTITIONED BY SPEC (s) > What happens when we have PARTITIONED BY SPEC (TRUNCATE(1, s))? We get only two partitions, dropping the partitions produce: Query: ALTER TABLE iceberg_drop_partition_like_test DROP PARTITION (s LIKE 'd%') +------------------------+ | summary | +------------------------+ | Dropped 1 partition(s) | +------------------------+ Fetched 1 row(s) in 0.83s The `SELECT s FROM iceberg_drop_partition_like_test ORDER BY s;` output is still the same. http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test: http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test@211 PS3, Line 211: # Test: LIKE with UTF-8 prefix pattern - should use startsWith pushdown : SELECT s FROM ice_utf8_test WHERE s LIKE 'árvíz%' ORDER BY s; > We should already push down predicates on 's' since it is a partitioning co Done http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test@339 PS3, Line 339: ---- RUNTIME_PROFILE : row_regex: .*partitions=1.*files= > Can this be put in RUNTIME_PROFILE section of the following query block? Sa Done http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test: http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test@486 PS3, Line 486: ---- TYPES > Can you add RESULTS section with row_regexes? Done -- To view, visit http://gerrit.cloudera.org:8080/24045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c11362f098507fa440eafde3c35bbc6d7092b3 Gerrit-Change-Number: 24045 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2026 18:30:45 +0000 Gerrit-HasComments: Yes
