Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24045 )
Change subject: IMPALA-14737 Part2: Add relaxed predicate pushdown for LIKE patterns with suffix ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24045/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/24045/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@1114 PS1, Line 1114: : if (result.isFailed()) { : untranslatedExpressions_.add(expr); : return false; : } : : Expression icebergExpr = result.getIcebergExpression(); : impalaIcebergPredicateMapping_.put(icebergExpr, expr); : LOG.debug("Push down the predicate: {} to iceberg (status={})", : icebergExpr, result.getStatus()); : > 1. Yeah, a new ConverterResult class make sense. Alternatively you can use Thanks for the pointers. For the fourth point, no we didnt have the support as IcebergPartitionExpressionRewriter did not handle LikePredicate at all. Before part 2, LIKE was totally unsupported in SHOW FILES/DROP PARTITIONS and they would throw this exception "AnalysisException: Invalid partition filtering expression: s LIKE 'd%'". After part 2, the simple LIKE patterns will work and complex ones will throw exception. -- To view, visit http://gerrit.cloudera.org:8080/24045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c11362f098507fa440eafde3c35bbc6d7092b3 Gerrit-Change-Number: 24045 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 04 Mar 2026 11:01:40 +0000 Gerrit-HasComments: Yes
