Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24045 )
Change subject: IMPALA-14737 Part2: Add relaxed predicate pushdown for LIKE patterns with suffix ...................................................................... Patch Set 3: (6 comments) Left a few small comments, but looks good overall. http://gerrit.cloudera.org:8080/#/c/24045/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24045/3//COMMIT_MSG@16 PS3, Line 16: , we now: nit: we have a 72 chars limit for the body of the commit message http://gerrit.cloudera.org:8080/#/c/24045/3/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java: http://gerrit.cloudera.org:8080/#/c/24045/3/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java@171 PS3, Line 171: Cannot use LIKE pattern with Currently, only the LIKE predicate can be partially converted, but for future compatibility, the message needs to be formulated more generally, e.g.: Given predicate '%s' can only be partially converted to Iceberg expression: '%s', so it is not allowed to be used for DROP PARTITION. Or, if you want to provide more specific details, then it should come from ConverterResult. Same goes for SHOW FILEs. http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test: http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test@502 PS3, Line 502: PARTITIONED BY SPEC (s) What happens when we have PARTITIONED BY SPEC (TRUNCATE(1, s))? http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test: http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test@211 PS3, Line 211: # Enable pushdown for non-identity partition column 's' (partitioned by truncate(5, s)) : ALTER TABLE ice_utf8_test SET TBLPROPERTIES('impala.iceberg.push_down_hint'='s'); We should already push down predicates on 's' since it is a partitioning column (even if it is TRUNCATE-based). E.g. "EXPLAIN SELECT s FROM ice_utf8_test WHERE s > 'árvíz' and s < 'árz' ORDER BY s;" pushes down predicates for me. http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-like-pushdown.test@339 PS3, Line 339: row_regex:.*HDFS partitions=1/8.* : row_regex:.*predicates:.*s LIKE.* Can this be put in RUNTIME_PROFILE section of the following query block? Same goes for L357-358. http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test: http://gerrit.cloudera.org:8080/#/c/24045/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test@486 PS3, Line 486: ---- TYPES Can you add RESULTS section with row_regexes? -- To view, visit http://gerrit.cloudera.org:8080/24045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97c11362f098507fa440eafde3c35bbc6d7092b3 Gerrit-Change-Number: 24045 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2026 13:40:27 +0000 Gerrit-HasComments: Yes
