Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24104 )
Change subject: IMPALA-14839: Add counters for slowest channels in KrpcDataStreamSenders ...................................................................... Patch Set 3: > This seems useful. Could use a test. "Could use a test." I am unsure about the usefulness of adding tests for this kind of diagnostic features, the test will be much more complex than the change itself. I guess this would need new kind of debug actions to only introduce delay is specific host in a query to ensure that there is a "slowest" network / receiver. Maybe move this to another ticket? Such debug actions could be useful for other things too. -- To view, visit http://gerrit.cloudera.org:8080/24104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e56dab3603ea6c5fb345793485af6ed52613046 Gerrit-Change-Number: 24104 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Sat, 11 Apr 2026 10:42:40 +0000 Gerrit-HasComments: No
