Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24229 )
Change subject: IMPALA-14916/IMPALA-14113: Display Calcite plan in EXPLAIN output ...................................................................... Patch Set 1: (3 comments) Please resolve the merge conflict. http://gerrit.cloudera.org:8080/#/c/24229/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24229/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-14916/IMPALA-14113: Display Calcite plan in EXPLAIN output Let's confine this to one ticket. This set of changes seems fine as a single patch, so maybe we use IMPALA-14916 and close IMPALA-14113 saying it's covered by the other ticket. http://gerrit.cloudera.org:8080/#/c/24229/1/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/24229/1/common/thrift/Query.thrift@822 PS1, Line 822: 202: optional bool enable_explain_calcite = false; > Indeed we can set the default to true without affecting much since its a NO I lean towards keeping it off for now. I don't think it's relevant unless we're debugging Calcite itself. http://gerrit.cloudera.org:8080/#/c/24229/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlannerIntf.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlannerIntf.java: http://gerrit.cloudera.org:8080/#/c/24229/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlannerIntf.java@49 PS1, Line 49: String calcitePlan(); nit: would look nicer with a comment describing what the function should do. -- To view, visit http://gerrit.cloudera.org:8080/24229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec51e2b4315e95020e1826acfa477aaea4c45601 Gerrit-Change-Number: 24229 Gerrit-PatchSet: 1 Gerrit-Owner: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 21:50:31 +0000 Gerrit-HasComments: Yes
