Hello Abhishek Talluri, Zoltan Borok-Nagy, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24554
to look at the new patch set (#4).
Change subject: IMPALA-5924: Formatting TBLPROPERTIES in SHOW CREATE TABLE
......................................................................
IMPALA-5924: Formatting TBLPROPERTIES in SHOW CREATE TABLE
When we run SHOW CREATE TABLE via Impala-shell output displays the
TBLPROPERTIES in a single line which makes it difficult to read
through all the properties.
Change:
Modified ToSqlUtils.java to wrap reconstructed TBLPROPERTIES into a
clean multi-line, indented layout instead of outputting them as a
single dense line.
Modified ToSqlTest.java to update the expected string assertions to
match the new multi-line format.
Modified test_kudu.py and LocalCatalogTest.java to match the expected DDL
output.
Example:
Before this change, TBLPROPERTIES were formatted on a single line in
SHOW CREATE TABLE output:
TBLPROPERTIES ('OBJCAPABILITIES'='HIVEMANAGEDINSERTREAD...', ...)
After this change, they are cleanly wrapped:
TBLPROPERTIES (
'OBJCAPABILITIES'='EXTREAD,EXTWRITE',
'TRANSLATED_TO_EXTERNAL'='TRUE',
'external.table.purge'='TRUE'
)
This improves the readability of generated DDL statements when
executing SHOW CREATE TABLE or viewing view definitions via
impala-shell.
Testing Performed:
- Updated expected string outputs in ToSqlTest.java to account for the
new whitespace layouts.
- Verified frontend changes compile cleanly using checkstyle.
- Ran mvn clean package -DskipTests (BUILD SUCCESS).
- Ran focus testing suite: mvn test -Dtest=ToSqlTest
(BUILD SUCCESS).
- Ran idempotency integrity validation suite:
mvn test -Dtest=ToSqlUtilsTest (BUILD SUCCESS).
- python3 bin/jenkins/critique-gerrit-review.py --dryrun
- tests/run-tests.py query_test/test_kudu.py
- mvn -Dtest=LocalCatalogTest#testHbaseTable test
- This change will list the TBLPROPERTIES for Hbase tables as well.
Change-Id: Ic198d0a42cf3636fe612460c12d8c8000a313ef1
Signed-off-by: Gowthami Bisati <[email protected]>
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
M tests/query_test/test_kudu.py
4 files changed, 100 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/24554/4
--
To view, visit http://gerrit.cloudera.org:8080/24554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic198d0a42cf3636fe612460c12d8c8000a313ef1
Gerrit-Change-Number: 24554
Gerrit-PatchSet: 4
Gerrit-Owner: Gowthami Bisati <[email protected]>
Gerrit-Reviewer: Abhishek Talluri <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
