Gowthami Bisati has posted comments on this change. ( http://gerrit.cloudera.org:8080/24554 )
Change subject: IMPALA-5924: Formatting TBLPROPERTIES in SHOW CREATE TABLE ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@1104 PS7, Line 1104: > nit: indentation is off corrected the indentation http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@a425 PS7, Line 425: > nit: Please don't remove this empty line sure http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@459 PS7, Line 459: > Leftover debug message removed http://gerrit.cloudera.org:8080/#/c/24554/7/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/24554/7/tests/query_test/test_kudu.py@1112 PS7, Line 1112: 'k > Why do we have misaligned indentation here and below? this was due to the culprit in test.py which is adding the extra 2 spaces indendation to the 2 line of the Tblproperties .output = output.replace("'external.table.purge'='TRUE', ", "") -- To view, visit http://gerrit.cloudera.org:8080/24554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic198d0a42cf3636fe612460c12d8c8000a313ef1 Gerrit-Change-Number: 24554 Gerrit-PatchSet: 9 Gerrit-Owner: Gowthami Bisati <[email protected]> Gerrit-Reviewer: Abhishek Talluri <[email protected]> Gerrit-Reviewer: Gowthami Bisati <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 23 Jul 2026 08:35:48 +0000 Gerrit-HasComments: Yes
