Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24554 )
Change subject: IMPALA-5924: Formatting TBLPROPERTIES in SHOW CREATE TABLE ...................................................................... Patch Set 7: (4 comments) Left a few small comments. As mentioned offline, please run the following command locally: bin/impala-py.test --exploration_strategy=exhaustive tests/custom_cluster/test_workload_mgmt_init.py http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@1104 PS7, Line 1104: nit: indentation is off http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@a425 PS7, Line 425: nit: Please don't remove this empty line http://gerrit.cloudera.org:8080/#/c/24554/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@459 PS7, Line 459: System.out.println(t.getColumns()); Leftover debug message http://gerrit.cloudera.org:8080/#/c/24554/7/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/24554/7/tests/query_test/test_kudu.py@1112 PS7, Line 1112: Why do we have misaligned indentation here and below? -- To view, visit http://gerrit.cloudera.org:8080/24554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic198d0a42cf3636fe612460c12d8c8000a313ef1 Gerrit-Change-Number: 24554 Gerrit-PatchSet: 7 Gerrit-Owner: Gowthami Bisati <[email protected]> Gerrit-Reviewer: Abhishek Talluri <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 14:08:00 +0000 Gerrit-HasComments: Yes
