Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24521 )
Change subject: IMPALA-15052: Add read support for unshredded VARIANT values ...................................................................... Patch Set 13: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24521/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24521/12//COMMIT_MSG@44 PS12, Line 44: is reported as STRING/VARCHAR, > there is a recent PR in Hive about this: https://github.com/apache/hive/pul It's still in progress for Hive. I think for now the safest is to return STRING, this will surely work with old clients. For most users it is an implementation detail when the VARIANT object gets converted to a JSON string. We can even document that VARIANT's client facing behavior is subject to change. Please feel free to file a follow-up Jira ticket about client behavior. http://gerrit.cloudera.org:8080/#/c/24521/12/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/24521/12/fe/src/main/java/org/apache/impala/catalog/Type.java@779 PS12, Line 779: if (isVariantType()) return java.sql.Types.VARCHAR; > The JDBC connector could be also tested, see https://github.com/apache/imp Added it. It requires loading the trino_variant table during data loading. -- To view, visit http://gerrit.cloudera.org:8080/24521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f8a7c9b1d4e5f6a0c3b8d7e9f1a2b4c6d8e0f1 Gerrit-Change-Number: 24521 Gerrit-PatchSet: 13 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 09:12:37 +0000 Gerrit-HasComments: Yes
