Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24521 )
Change subject: IMPALA-15052: Add read support for unshredded VARIANT values ...................................................................... Patch Set 14: Code-Review+1 (2 comments) +1 and comment about commit message can upgrade to +2 if others don't plan to chime in http://gerrit.cloudera.org:8080/#/c/24521/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24521/12//COMMIT_MSG@44 PS12, Line 44: is reported as STRING/VARCHAR, > It's still in progress for Hive. I think for now the safest is to return ST >We can even document that VARIANT's client facing behavior is subject to >change. agree - can you add to the commit message that client interface is not finalized, as the Hive solution is also work in progress? I am torn about the best solution, the more distinctly we identify variant as a new type, the more work clients will need to support it. http://gerrit.cloudera.org:8080/#/c/24521/14/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/24521/14/testdata/datasets/functional/functional_schema_template.sql@3285 PS14, Line 3285: `{ rm -rf /tmp/impala_trino_variant_stage && \ : mkdir -p /tmp/impala_trino_variant_stage && \ : cp -r ${IMPALA_HOME}/testdata/data/iceberg_test/iceberg_v3/trino_variant /tmp/impala_trino_variant_stage/ && \ : PYTHONPATH=${IMPALA_HOME} ${IMPALA_HOME}/testdata/bin/rewrite-iceberg-metadata.py "" /tmp/impala_trino_variant_stage/trino_variant/metadata && \ : hadoop fs -rm -r -f -skipTrash /test-warehouse/trino_variant && \ : hadoop fs -put -d /tmp/impala_trino_variant_stage/trino_variant /test-warehouse/ && \ : rm -rf /tmp/impala_trino_variant_stage ; } >/dev/null I don't intend to do this in the current commit, but I hope that we'll have a nicer way to do this in the future. This file became anything but a declerative "sql" file. -- To view, visit http://gerrit.cloudera.org:8080/24521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f8a7c9b1d4e5f6a0c3b8d7e9f1a2b4c6d8e0f1 Gerrit-Change-Number: 24521 Gerrit-PatchSet: 14 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 18:34:58 +0000 Gerrit-HasComments: Yes
