Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24572 )
Change subject: IMPALA-15171: Null out Iceberg delete file path slot after the join ...................................................................... Patch Set 7: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/24572/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24572/5//COMMIT_MSG@9 PS5, Line 9: IcebergScanPlanner materializes the INPUT__FILE__NAME (file path) > Using INPUT__FILE__NAME in the Scan and Delete operator's fragment is quite ack, yeah, for pure v3 tables doing it in the scanner seems the cleanest and most efficient, and then there will be no extra slots at all I didn't realize that that path is always kept only once in memory and is not duplicated (at least after your patch) http://gerrit.cloudera.org:8080/#/c/24572/5//COMMIT_MSG@10 PS5, Line 10: position-delete join : (IcebergDeleteJoinNode) can use it as a join key. > on their position ack, I guess it is needed to pass the path from the scan node to the delete node http://gerrit.cloudera.org:8080/#/c/24572/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/24572/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@443 PS5, Line 443: // this call materializes it solely for the delete join, so the backend can null it : // out on the join output. : Path resolvedPath; Is there a reason why we can assume that this is the last time someone would try to use the slot? This may worth some explanation. -- To view, visit http://gerrit.cloudera.org:8080/24572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e662cb6a98dd3e687185d384731d6be45f91b94 Gerrit-Change-Number: 24572 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 16:28:54 +0000 Gerrit-HasComments: Yes
