Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24572 )
Change subject: IMPALA-15171: Null out Iceberg delete file path slot after the join ...................................................................... Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java: http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java@177 PS8, Line 177: if (clearFilePathSlot_) { : output.append(detailPrefix + "clear file path slot\n"); : } > I think EXTENDED level would be better so we would see them in query profil I am still in team VERBOSE, but ack http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@311 PS8, Line 311: oops, I didn't check the call site > E.g. HdfsScanNode should always invoke getDerivedExplainString() and here we > should gate messages based on explain level. Agree, this would be clearer, I am ok with changing it here or postponing it. -- To view, visit http://gerrit.cloudera.org:8080/24572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e662cb6a98dd3e687185d384731d6be45f91b94 Gerrit-Change-Number: 24572 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 09:57:38 +0000 Gerrit-HasComments: Yes
