Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24572 )
Change subject: IMPALA-15171: Null out Iceberg delete file path slot after the join ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/24572/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/24572/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@443 PS5, Line 443: // If the file path slot is not registered yet, then no expression references it and : // this call materializes it solely for the delete join, so the backend can null it : // out on the join output. > Is there a reason why we can assume that this is the last time someone woul This is invoked during the planning phase, the Analyzer should have already added slots that are referenced by the query. Currently no later planning phase adds this slot either, and probably no other slots either. I don't know how to enforce this other than proper testing. But I think it's quite unlikely that something would also add the file path slot ref. Or, if the problem is that the current comment isn't precise enough, please propose a new comment message for this. -- To view, visit http://gerrit.cloudera.org:8080/24572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e662cb6a98dd3e687185d384731d6be45f91b94 Gerrit-Change-Number: 24572 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 17:54:46 +0000 Gerrit-HasComments: Yes
