Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 22: (3 comments) http://gerrit.cloudera.org:8080/#/c/24426/20/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/20/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@145 PS20, Line 145: List<SlotRef> slotRefs = new ArrayList<>(); > I think "expr.collect(SlotRef.class, slotRefs)" can be used instead of getN Done http://gerrit.cloudera.org:8080/#/c/24426/20/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24426/20/fe/src/main/java/org/apache/impala/planner/PlanNode.java@219 PS20, Line 219: // Empty when this node's subtree exposes no join (a single unqualified operand). > Nit: carriage return Don't need this variable now. http://gerrit.cloudera.org:8080/#/c/24426/20/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1103 PS20, Line 1103: if (prefix.isEmpty()) return Collections.emptyMap(); > Suggestion on this: Agree that this looks cleaner. I made the changes except for AggregationNode which uses the default implementation for PlanNode. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 22 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2026 15:46:30 +0000 Gerrit-HasComments: Yes
